Repository navigation
Stop using remaining_jobs and failed_jobs and use jobs statuses instead - #5165
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the PresubmitGuard and GuardStatus logic to eliminate the redundant tracking of remainingJobs and failedJobs counters, opting instead to dynamically calculate the guard status directly from the individual job statuses. Numerous request handlers, services, and tests have been updated to support this simplified approach. Additionally, three new users were added to the resetFailedCheckRun configuration. No review comments were provided, so there is no feedback to address.
ievdokdm
changed the title
ievdokdm
force-pushed
the
193862-reamining
branch
from
October 8, 2026 20:40
51524d8 to
07ddfe4
Compare
ievdokdm
force-pushed
the
193862-reamining
branch
from
October 13, 2026 20:29
c5fca78 to
cf33486
Compare
ievdokdm
force-pushed
the
193862-reamining
branch
from
October 15, 2026 16:40
cf33486 to
cd3654f
Compare
ievdokdm
added
the
autosubmit
jtmcdole
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove remaining_jobs and failed_jobs from presubmit_guards
Remove the remaining_jobs and failed_jobs fields from PresubmitGuard and derive guard status directly from the jobs TaskStatus map instead of maintaining separate counters.
fix: flutter/flutter#193862